Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: nft collections getownednfts createlisting getfloorlistings #2189

Conversation

IkigaiLabsETH
Copy link
Contributor

Relates to

Risks

  • Low Risk
    • Adds new API integration methods to NFT collections service
    • No breaking changes to existing interfaces
    • Introduces additional error handling and performance monitoring

Background

What does this PR do?

Implements three key methods in the ReservoirService for NFT collections:

  • getOwnedNFTs: Fetch NFTs owned by a specific address
  • createListing: Create a new NFT listing on Reservoir marketplace
  • getFloorListings: Retrieve floor listings for a specific collection

What kind of change is this?

  • Features (non-breaking change which adds functionality)
  • Improvements to NFT collections plugin

Documentation changes needed?

My changes require a change to the project documentation.

  • Update README.md for plugin-nft-collections
  • Add method descriptions in code comments

Testing

Where should a reviewer start?

  • Review packages/plugin-nft-collections/src/services/reservoir.ts
  • Focus on the newly implemented methods

Detailed testing steps

  1. Unit Tests

    • Verify getOwnedNFTs returns correct NFT data structure
    • Test createListing with various input parameters
    • Validate getFloorListings sorting and filtering
  2. Integration Tests

    • Test methods with real Reservoir API credentials
    • Verify error handling mechanisms
    • Check performance monitoring functionality
  3. Manual Verification

    • Test each method with sample collection and token addresses
    • Validate marketplace URL generation
    • Confirm error logging works as expected

Additional Notes

  • Implemented with comprehensive error handling
  • Added performance monitoring for API calls
  • Follows existing service interface and design patterns

tcm390 and others added 24 commits January 11, 2025 17:52
…vice

- Add comprehensive createListing method for Reservoir API
- Include parameter validation and default values
- Implement error handling and performance monitoring
- Generate marketplace URL for listed token
…Service

- Add comprehensive getFloorListings method for Reservoir API
- Support sorting by price and rarity
- Implement detailed error handling and performance monitoring
- Transform API response to standardized format
@odilitime odilitime changed the title Feature/nft collections getownednfts createlisting getfloorlistings feat: nft collections getownednfts createlisting getfloorlistings Jan 12, 2025
@odilitime odilitime changed the base branch from main to develop January 12, 2025 09:11
@wtfsayo
Copy link
Member

wtfsayo commented Jan 15, 2025

Screenshot 2025-01-15 at 11 53 52 AM

please don't check in all these

@wtfsayo wtfsayo closed this Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants